[FFmpeg-devel] [PATCH 9/9] Make avfilter_graph_parse() always return meaningful error codes.

Stefano Sabatini stefano.sabatini-lala
Sun Nov 7 19:39:54 CET 2010


On date Sunday 2010-11-07 16:03:19 +0100, Michael Niedermayer encoded:
> On Sun, Nov 07, 2010 at 03:51:23PM +0100, Stefano Sabatini wrote:
> > On date Friday 2010-11-05 18:20:33 +0100, Stefano Sabatini encoded:
> > > ---
> > >  libavfilter/graphparser.c |   22 ++++++++++++----------
> > >  1 files changed, 12 insertions(+), 10 deletions(-)
> > 
> > I'll apply the whole in three days if there are no objections.
> 
> I have no objections to this patchset except that the error codes need to be
> checked.
> simply passing error codes from a function to the outter is not guranteed to
> be correct.
> for ENOMEM surely it should work out most of the time, but a EINVAL for a
> function is not neccesarily a EINVAL for the outer function
> 
> if you checked these things then ok

Applied patchset.
-- 
FFmpeg = Fabulous and Fierce Monstrous Ponderous Elastic Guru



More information about the ffmpeg-devel mailing list