[FFmpeg-devel] [PATCH 9/9] Make avfilter_graph_parse() always return meaningful error codes.

[Michael Niedermayer]

On Sun, Nov 07, 2010 at 03:51:23PM +0100, Stefano Sabatini wrote:
> On date Friday 2010-11-05 18:20:33 +0100, Stefano Sabatini encoded:
> > ---
> >  libavfilter/graphparser.c |   22 ++++++++++++----------
> >  1 files changed, 12 insertions(+), 10 deletions(-)
> 
> I'll apply the whole in three days if there are no objections.

I have no objections to this patchset except that the error codes need to be
checked.
simply passing error codes from a function to the outter is not guranteed to
be correct.
for ENOMEM surely it should work out most of the time, but a EINVAL for a
function is not neccesarily a EINVAL for the outer function

if you checked these things then ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101107/514aed55/attachment.pgp>