[FFmpeg-devel] [PATCH] Make x11grab cursor drawing suck less

[Luca Barbato]

On 11/7/10 8:18 AM, Jason Garrett-Glaser wrote:
> <rant>
> X11's API provides unsigned image data through a char* pointer.
> X11's API provides unsigned image data through a char* pointer.
> X11's API provides unsigned image data through a char* pointer.
>
> WHAT THE CHRIST?!!
> </rant>

xcb-utils might have something saner... sadly there are not enough 
people using and developing xcb.

> This patch does a variety of things to make x11grab's cursor-drawing suck less.
>
> 1.  It now works on 24-bit and 32-bit image data, not just 32-bit.
> Previously, it probably broke horribly on 24-bit. However, since I've
> never seen a single bug report about this, I doubt modern X11 actually
> uses anything less...
> 2.  It now doesn't try to run on 16-bit or PAL8 (making the code
> handle 16-bit or PAL8 would be much outside the scope of this, and
> impossible to test).
> 3.  It now does proper alpha-blending.  Cursors with shadows don't
> look like utter crap anymore.
>
> Did I mention I hate X11 with the fury of a thousand suns?

You hate libX11 as you should. xcb is a bit better.

lu