[FFmpeg-devel] [PATCH] Make x11grab cursor drawing suck less

[Jason Garrett-Glaser]

On Sun, Nov 7, 2010 at 7:08 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Nov 07, 2010 at 12:18:23AM -0700, Jason Garrett-Glaser wrote:
>> <rant>
>> X11's API provides unsigned image data through a char* pointer.
>> X11's API provides unsigned image data through a char* pointer.
>> X11's API provides unsigned image data through a char* pointer.
>>
>> WHAT THE CHRIST?!!
>> </rant>
>>
>> This patch does a variety of things to make x11grab's cursor-drawing suck less.
>>
>> 1. ?It now works on 24-bit and 32-bit image data, not just 32-bit.
>> Previously, it probably broke horribly on 24-bit. However, since I've
>> never seen a single bug report about this, I doubt modern X11 actually
>> uses anything less...
>> 2. ?It now doesn't try to run on 16-bit or PAL8 (making the code
>> handle 16-bit or PAL8 would be much outside the scope of this, and
>> impossible to test).
>> 3. ?It now does proper alpha-blending. ?Cursors with shadows don't
>> look like utter crap anymore.
>>
>> Did I mention I hate X11 with the fury of a thousand suns?
>>
>> Dark Shikari
>
>> ?x11grab.c | ? 33 +++++++++++++++++++++++----------
>> ?1 file changed, 23 insertions(+), 10 deletions(-)
>> d4ac073474cff667319aecef2008079594259515 ?x11grab_fix.diff
>
> we need a maintainer for x11grab.c, any volunteers?
> if not then this patch lgtm

Applied, I'd maintain but I don't really have a real Linux box to
maintain with...

Dark Shikari