[FFmpeg-devel] [PATCH 1/3] Implement parse_preset_line() and use it in ffmpeg.c and ffserver.c.

[Michael Niedermayer]

On Sun, Nov 07, 2010 at 10:48:38AM +0100, Stefano Sabatini wrote:
> On date Sunday 2010-11-07 01:06:36 +0100, Michael Niedermayer encoded:
> > On Sat, Nov 06, 2010 at 03:02:39PM +0100, Stefano Sabatini wrote:
> > > ---
> > >  cmdutils.c |   24 ++++++++++++++++++++++++
> > >  cmdutils.h |   15 +++++++++++++++
> > >  ffmpeg.c   |   14 ++++----------
> > >  ffserver.c |   12 ++----------
> > 
> > >  4 files changed, 45 insertions(+), 20 deletions(-)
> > 
> > if this is code factorization its making the code >2x larger instead of smaller
> 
> It's because of the docs and the function header overhead, also sscanf

that makes 15 lines, the patch is still worsening it by 50%


> doesn't allow to write in a string with given variable size, so I need
> to copy the string back to the user provided buffers.
> 
> But the point of the patch is not to reduce the line count, but
> avoiding code duplication (see also patch #2).

I understand that, it still doesnt look all that much like a improvment to me

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101107/fec610b8/attachment.pgp>