[FFmpeg-devel] [PATCH 1/3] Implement parse_preset_line() and use it in ffmpeg.c and ffserver.c.

[Stefano Sabatini]

On date Sunday 2010-11-07 01:06:36 +0100, Michael Niedermayer encoded:
> On Sat, Nov 06, 2010 at 03:02:39PM +0100, Stefano Sabatini wrote:
> > ---
> >  cmdutils.c |   24 ++++++++++++++++++++++++
> >  cmdutils.h |   15 +++++++++++++++
> >  ffmpeg.c   |   14 ++++----------
> >  ffserver.c |   12 ++----------
> 
> >  4 files changed, 45 insertions(+), 20 deletions(-)
> 
> if this is code factorization its making the code >2x larger instead of smaller

It's because of the docs and the function header overhead, also sscanf
doesn't allow to write in a string with given variable size, so I need
to copy the string back to the user provided buffers.

But the point of the patch is not to reduce the line count, but
avoiding code duplication (see also patch #2).
-- 
FFmpeg = Fostering and Fast Moronic Philosofic Erotic Gadget