[FFmpeg-devel] [PATCH] Make x11grab cursor drawing suck less

[Michael Niedermayer]

On Sun, Nov 07, 2010 at 12:18:23AM -0700, Jason Garrett-Glaser wrote:
> <rant>
> X11's API provides unsigned image data through a char* pointer.
> X11's API provides unsigned image data through a char* pointer.
> X11's API provides unsigned image data through a char* pointer.
> 
> WHAT THE CHRIST?!!
> </rant>
> 
> This patch does a variety of things to make x11grab's cursor-drawing suck less.
> 
> 1.  It now works on 24-bit and 32-bit image data, not just 32-bit.
> Previously, it probably broke horribly on 24-bit. However, since I've
> never seen a single bug report about this, I doubt modern X11 actually
> uses anything less...
> 2.  It now doesn't try to run on 16-bit or PAL8 (making the code
> handle 16-bit or PAL8 would be much outside the scope of this, and
> impossible to test).
> 3.  It now does proper alpha-blending.  Cursors with shadows don't
> look like utter crap anymore.
> 
> Did I mention I hate X11 with the fury of a thousand suns?
> 
> Dark Shikari

>  x11grab.c |   33 +++++++++++++++++++++++----------
>  1 file changed, 23 insertions(+), 10 deletions(-)
> d4ac073474cff667319aecef2008079594259515  x11grab_fix.diff

we need a maintainer for x11grab.c, any volunteers?
if not then this patch lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101107/2b7ed114/attachment.pgp>