[FFmpeg-devel] [PATCH] H.264 interlaced crop fate test

[Reimar Döffinger]

On Thu, Nov 04, 2010 at 12:23:07AM +0100, Michael Niedermayer wrote:
> On Wed, Nov 03, 2010 at 10:10:15PM +0100, Reimar D?ffinger wrote:
> > Hello,
> > I don't think it's controversial, but since I have to wait for rsync anyway...
> > Please raise any objections by tomorrow or after that on -cvslog :-)
> 
> does this really need that many frames to be decoded?

No, 1 or 2 or so should be enough.

> and do we already have a test that tests the max frames cmd line parameter?

Probably not.
I take this to mean you'd rather have the below?
I have no idea if it makes a difference where I put -vframes and which is
better to test...

Index: tests/fate/h264.mak
===================================================================
--- tests/fate/h264.mak (revision 25668)
+++ tests/fate/h264.mak (working copy)
@@ -164,7 +164,7 @@
             sva_nl1_b                                                   \
             sva_nl2_e                                                   \
 
-FATE_H264  := $(FATE_H264:%=fate-h264-conformance-%)
+FATE_H264  := $(FATE_H264:%=fate-h264-conformance-%) fate-h264-interlace-crop
 FATE_TESTS += $(FATE_H264)
 fate-h264: $(FATE_H264)
 
@@ -333,3 +333,5 @@
 fate-h264-conformance-sva_fm1_e: CMD = framecrc  -i $(SAMPLES)/h264-conformance/SVA_FM1_E.264
 fate-h264-conformance-sva_nl1_b: CMD = framecrc  -i $(SAMPLES)/h264-conformance/SVA_NL1_B.264
 fate-h264-conformance-sva_nl2_e: CMD = framecrc  -i $(SAMPLES)/h264-conformance/SVA_NL2_E.264
+
+fate-h264-interlace-crop: CMD = framecrc  -vframes 3 -i $(SAMPLES)/h264/interlaced_crop.mp4
Index: tests/ref/fate/h264-interlace-crop
===================================================================
--- tests/ref/fate/h264-interlace-crop  (revision 0)
+++ tests/ref/fate/h264-interlace-crop  (revision 0)
@@ -0,0 +1,3 @@
+0, 0, 345600, 0xa9cb7e5a
+0, 3600, 345600, 0x73e47555
+0, 7200, 345600, 0x87aac593