[FFmpeg-devel] Patch for issue 1973 (targa decoder crash on corrupted file)

[Jean-Daniel Dupas]

Le 29 mai 2010 ? 16:07, Kostya a ?crit :

> On Sat, May 29, 2010 at 01:56:44PM +0200, Jean-Daniel Dupas wrote:
>> Hello,
>> 
>> This is a tentative patch to fix some crash in the targa parser.
>> Can someone review it ? 
>> Thanks.
> 
> In principle patch ok, but there are few nits:
> * you break existing long lines in your patch - like RLE function
>  definition. That's good but should belong to other patch.

Event if this patch add a new argument ? 

> * why bother with buf_size while you can just have one constant buf_end
>  and check buf + size <= buf_end ?

Good point.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tga_check.patch
Type: application/octet-stream
Size: 4614 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100529/540f44f6/attachment.obj>
-------------- next part --------------

-- Jean-Daniel