[FFmpeg-devel] Patch for issue 1973 (targa decoder crash on corrupted file)

Kostya kostya.shishkov
Sat May 29 16:07:14 CEST 2010

On Sat, May 29, 2010 at 01:56:44PM +0200, Jean-Daniel Dupas wrote:
> Hello,
> This is a tentative patch to fix some crash in the targa parser.
> Can someone review it ? 
> Thanks.
In principle patch ok, but there are few nits:
* you break existing long lines in your patch - like RLE function
  definition. That's good but should belong to other patch.
* why bother with buf_size while you can just have one constant buf_end
  and check buf + size <= buf_end ?

More information about the ffmpeg-devel mailing list