[FFmpeg-devel] [PATCH] IFF: Merge lots of duplicate code into a single function

Sebastian Vater cdgs.basty
Sat May 15 19:01:07 CEST 2010

Ronald S. Bultje a ?crit :
> Hi,
> On Fri, May 14, 2010 at 9:48 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
> [..]
>> + * @return returns pointer to the source stream's end of line
> I find the return value a bit iffy, I'd expect it to return bytes
> consumed (and then callers do buf += decodebyterun()). What do others
> think? I don't want to bikeshed over this but just want some input
> from other devs.

That's the only way I'm using this function, though.

Since it has to continue decoding on that position anyway, there would
just go in more complexicity without real gain.

> Also, now is a great moment to introduce the concept of underscores,
> dontcallyourfunctionstoolongnames() isn't great for readability, I'd
> suggest decode_byterun() instead.



Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-function-merge.patch
Type: text/x-patch
Size: 5307 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100515/1c515eec/attachment.bin>

More information about the ffmpeg-devel mailing list