[FFmpeg-devel] [PATCH] IFF: Merge lots of duplicate code into a single function

Ronald S. Bultje rsbultje
Sat May 15 18:03:04 CEST 2010


On Fri, May 14, 2010 at 9:48 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> + * @return returns pointer to the source stream's end of line

I find the return value a bit iffy, I'd expect it to return bytes
consumed (and then callers do buf += decodebyterun()). What do others
think? I don't want to bikeshed over this but just want some input
from other devs.

Also, now is a great moment to introduce the concept of underscores,
dontcallyourfunctionstoolongnames() isn't great for readability, I'd
suggest decode_byterun() instead.


More information about the ffmpeg-devel mailing list