[FFmpeg-devel] [PATCH] E-AC-3 spectral extension (bump)

[Michael Niedermayer]

On Fri, Mar 26, 2010 at 05:44:08PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2010/3/26 Michael Niedermayer <michaelni at gmx.at>:
> >> + ? ? ? ? ? ?s->spx_dst_start_freq = copy_start;
> >> + ? ? ? ? ? ?s->spx_src_start_freq ? ? ?= start_freq;
> >> + ? ? ? ? ? ?s->spx_dst_end_freq ? ? ? ?= end_freq;
> >
> > vertical align
> > also the src/dst could beadded to the local 3 vars here
> [...]
> >> + ? ?int8_t spx_atten_code[AC3_MAX_CHANNELS]; ? ?///< spx attenuation code ? ? ? ? ? ? ? ? ? (spxattencod)
> >> + ? ?int spx_src_start_freq; ? ? ? ? ? ? ? ? ? ? ? ? ///< spx start frequency bin
> >> + ? ?int spx_dst_end_freq; ? ? ? ? ? ? ? ? ? ? ? ? ? ///< spx end frequency bin
> >> + ? ?int spx_dst_start_freq; ? ? ? ? ? ? ? ? ? ?///< spx starting frequency bin for copying (copystartmant)
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?///< the copy region ends at the start of the spx region.
> >
> > too
> 
> Vars renamed, alignment fixed.
> 
> >> + ? ? ? ?if (parse_spx_atten_data && get_bits1(gbc))
> >> + ? ? ? ? ? ?s->spx_atten_code[ch] = get_bits(gbc, 5);
> >> + ? ? ? ?else
> >
> > should have {}
> > didnt patcheck detect this?
> 
> It did, and I do remember brushing it off, assuming bitstream spec
> wouldn't change.
> Changed, whatever my reason was.
> 
> I also didn't add {} to places where it would only introduce a
> cosmetical change.
> 
> Best regards,
> Christophe

>  Changelog                 |    1 
>  libavcodec/ac3dec.c       |  119 ++++++++++++++++++++++++++++++++++++++++++----
>  libavcodec/ac3dec.h       |   47 ++++++++++++++++++
>  libavcodec/ac3dec_data.c  |    6 ++
>  libavcodec/ac3dec_data.h  |    1 
>  libavcodec/eac3dec.c      |  105 ++++++++++++++++++++++++++++++++++++----
>  libavcodec/eac3dec_data.c |   39 +++++++++++++++
>  libavcodec/eac3dec_data.h |    1 
>  8 files changed, 299 insertions(+), 20 deletions(-)
> 989de678ad9f88b3ed4d4f9c9bc40d46600db9c2  eac3_spx_11.diff

looks ok if tested (and also tested with tools/trasher files)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100329/b007a13a/attachment.pgp>