[FFmpeg-devel] [PATCH] E-AC-3 spectral extension (bump)

[Christophe Gisquet]

Hi,

2010/3/26 Michael Niedermayer <michaelni at gmx.at>:
>> + ? ? ? ? ? ?s->spx_dst_start_freq = copy_start;
>> + ? ? ? ? ? ?s->spx_src_start_freq ? ? ?= start_freq;
>> + ? ? ? ? ? ?s->spx_dst_end_freq ? ? ? ?= end_freq;
>
> vertical align
> also the src/dst could beadded to the local 3 vars here
[...]
>> + ? ?int8_t spx_atten_code[AC3_MAX_CHANNELS]; ? ?///< spx attenuation code ? ? ? ? ? ? ? ? ? (spxattencod)
>> + ? ?int spx_src_start_freq; ? ? ? ? ? ? ? ? ? ? ? ? ///< spx start frequency bin
>> + ? ?int spx_dst_end_freq; ? ? ? ? ? ? ? ? ? ? ? ? ? ///< spx end frequency bin
>> + ? ?int spx_dst_start_freq; ? ? ? ? ? ? ? ? ? ?///< spx starting frequency bin for copying (copystartmant)
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?///< the copy region ends at the start of the spx region.
>
> too

Vars renamed, alignment fixed.

>> + ? ? ? ?if (parse_spx_atten_data && get_bits1(gbc))
>> + ? ? ? ? ? ?s->spx_atten_code[ch] = get_bits(gbc, 5);
>> + ? ? ? ?else
>
> should have {}
> didnt patcheck detect this?

It did, and I do remember brushing it off, assuming bitstream spec
wouldn't change.
Changed, whatever my reason was.

I also didn't add {} to places where it would only introduce a
cosmetical change.

Best regards,
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eac3_spx_11.diff
Type: text/x-diff
Size: 21383 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100326/c9468b44/attachment.diff>