[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Stefano Sabatini]

On date Saturday 2010-03-27 15:10:01 +0100, Reimar D?ffinger encoded:
> On Sat, Mar 27, 2010 at 03:05:34PM +0100, Stefano Sabatini wrote:
> > On date Saturday 2010-03-27 07:39:14 +0530, Mohamed Naufal encoded:
> > > +    if (avctx->get_buffer(avctx, &s->frame) < 0) {
> > > +        av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
> > > +        return -1;
> > > +    }
> > 
> > if ((ret = avctx->get_buffer(avctx, &s->frame) < 0) {
> 
> Could we please get those assignments in ifs banned?
> In 99% of cases they only make the code harder to read
> without even the slightest advantage I can see.

They save you a line of code, good if you're a programmer/golf-player
and like to impress your friends with very compact code ;-).

And this is a rather bikesheddish issue, I suggest to just let the
code writer/maintainer choose the style which suits her better, at
least for this particular idiomatic syntax.

Regards.
-- 
FFmpeg = Faithless and Fancy Merciless Problematic Epic Genius