[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Reimar Döffinger]

On Sat, Mar 27, 2010 at 03:05:34PM +0100, Stefano Sabatini wrote:
> On date Saturday 2010-03-27 07:39:14 +0530, Mohamed Naufal encoded:
> > +    if (avctx->get_buffer(avctx, &s->frame) < 0) {
> > +        av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
> > +        return -1;
> > +    }
> 
> if ((ret = avctx->get_buffer(avctx, &s->frame) < 0) {

Could we please get those assignments in ifs banned?
In 99% of cases they only make the code harder to read
without even the slightest advantage I can see.