[FFmpeg-devel] [PATCH] RTMPE support

[Howard Chu]

M?ns Rullg?rd wrote:
> Howard Chu<hyc at highlandsun.com>  writes:
>> Michael Niedermayer wrote:
>>> i dont mind supporting external libs but i think it should not replace
>>> our implementation but coexist.
>>
>> This patch adds configure hooks to allow choosing one or the other.
>>
>> Index: configure
>> ===================================================================
>> --- configure	(revision 22672)
>> +++ configure	(working copy)
>> @@ -177,6 +177,7 @@
>>     --enable-libnut          enable NUT (de)muxing via libnut,
>>                              native (de)muxer exists [no]
>>     --enable-libopenjpeg     enable JPEG 2000 decoding via OpenJPEG [no]
>> +  --enable-librtmp         enable RTMP[E] support via librtmp [no]
>>     --enable-libschroedinger enable Dirac support via libschroedinger [no]
>>     --enable-libspeex        enable Speex decoding via libspeex [no]
>>     --enable-libtheora       enable Theora encoding via libtheora [no]
>> @@ -920,6 +921,7 @@
>>       libopencore_amrnb
>>       libopencore_amrwb
>>       libopenjpeg
>> +    librtmp
>>       libschroedinger
>>       libspeex
>>       libtheora
>> @@ -2613,6 +2615,7 @@
>>   enabled libopencore_amrnb&&  require libopencore_amrnb opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb -lm
>>   enabled libopencore_amrwb&&  require libopencore_amrwb opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb -lm
>>   enabled libopenjpeg&&  require libopenjpeg openjpeg.h opj_version -lopenjpeg
>> +enabled librtmp&&  require librtmp librtmp/rtmp.h RTMP_Init $(pkg-config --libs librtmp)
>
> Is it possible to use this without pkg-config?  pkg-config is
> notoriously broken, and we avoid it whenever possible.

That was my original reaction too. I only added pkg-config support to librtmp 
at uau's suggestion. But as a practical matter, it solves the issue that 
librtmp could be built with either OpenSSL or GnuTLS*, and I don't see any 
other "standard" way to discover which dependency is needed.

Of course, if you simply added an SVN reference to librtmp into the ffmpeg 
tree and built a private copy, then this wouldn't be a problem - we'd just add 
a configure switch to select which crypto library to use so we'd know, instead 
of having to ask/guess.

* will probably be adding support for CyaSSL also; makes life easier for Xbox 
XBMC and other embedded systems.
-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/