[FFmpeg-devel] [PATCH] RTMPE support

[Måns Rullgård]

Howard Chu <hyc at highlandsun.com> writes:

> Michael Niedermayer wrote:
>> On Fri, Mar 19, 2010 at 09:18:26AM +0200, Kostya wrote:
>>> On Thu, Mar 18, 2010 at 10:56:23PM -0700, Howard Chu wrote:
>>>> compn wrote:
>>>>> On Thu, 18 Mar 2010 14:20:07 -0700, Howard Chu wrote:
>>>>>> Carl Eugen Hoyos wrote:
>>>>>>> Howard Chu<hyc<at>    highlandsun.com>    writes:
>>>>>>> Before sending a new patch, the usefulness of adding a new external dependency
>>>>>>> should probably be discussed.
>>>>>>
>>>>>> Discussion is all well and good, but at the end of the day the original
>>>>>> question remains unanswered - do you want the new features or not. Now, or
>>>>>> later. This patch provides everything, now.
>>>>>
>>>>> i havent tested or reviewed, but i think ffmpeg://rtmp:// would coexist
>>>>> with this patch.
>>>>>
>>>>> this could be worked around kind of like how live555 tries rtsp://
>>>>> first, then mplayer's realrtsp tries rtsp://. but thats a lot of work
>>>>> for not a lot of gain.
>>>>
>>>> No gain. If the stream uses rtmp:// and SWF Verification, you just waste
>>>> time going thru the old code.
>>>
>>> I admit that RTMP support in FFmpeg is not that good because of lack of
>>> interest.
>>> And I'm more and more inclined to see it supported via something that
>>> does that work. Actually it's Adobe fault - if RTMP was stable we'd
>>> have working implementation by now and no need of external dependencies;
>>> but no, somebody decided it's a good idea to change handshake every
>>> couple of months and add some commands and not document anything.
>>>
>>> So until it's settled down it may be good to stash away current RTMP
>>> code and use rtmpdump. It has active developers and I'd rather spend my
>>> time on REing some codec. Unless someone wants to beef lavf version up.
>>
>> i dont mind supporting external libs but i think it should not replace
>> our implementation but coexist.
>
> This patch adds configure hooks to allow choosing one or the other.
>
> Index: configure
> ===================================================================
> --- configure	(revision 22672)
> +++ configure	(working copy)
> @@ -177,6 +177,7 @@
>    --enable-libnut          enable NUT (de)muxing via libnut,
>                             native (de)muxer exists [no]
>    --enable-libopenjpeg     enable JPEG 2000 decoding via OpenJPEG [no]
> +  --enable-librtmp         enable RTMP[E] support via librtmp [no]
>    --enable-libschroedinger enable Dirac support via libschroedinger [no]
>    --enable-libspeex        enable Speex decoding via libspeex [no]
>    --enable-libtheora       enable Theora encoding via libtheora [no]
> @@ -920,6 +921,7 @@
>      libopencore_amrnb
>      libopencore_amrwb
>      libopenjpeg
> +    librtmp
>      libschroedinger
>      libspeex
>      libtheora
> @@ -2613,6 +2615,7 @@
>  enabled libopencore_amrnb  && require libopencore_amrnb opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb -lm
>  enabled libopencore_amrwb  && require libopencore_amrwb opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb -lm
>  enabled libopenjpeg && require libopenjpeg openjpeg.h opj_version -lopenjpeg
> +enabled librtmp    && require librtmp librtmp/rtmp.h RTMP_Init $(pkg-config --libs librtmp)

Is it possible to use this without pkg-config?  pkg-config is
notoriously broken, and we avoid it whenever possible.

-- 
M?ns Rullg?rd
mans at mansr.com