[FFmpeg-devel] [patch]MMS protocol over TCP

[Michael Niedermayer]

On Thu, Mar 25, 2010 at 12:56:26AM +0800, zhentan feng wrote:
> Hi
> 
> On Wed, Mar 24, 2010 at 11:48 PM, Ronald S. Bultje <rsbultje at gmail.com>wrote:
> 
> > Hi,
> >
> > On Wed, Mar 24, 2010 at 11:30 AM, zhentan feng <spyfeng at gmail.com> wrote:
> > > On Wed, Mar 24, 2010 at 10:41 PM, Michael Niedermayer <michaelni at gmx.at
> > >wrote:
> > >> code duplication (in each object including this and using the function)
> > >> iam against this, declare the proper dependancies or if you have to move
> > >> this to a (maybe new) C file.
> > >> [...]
> > >
> > > yes you are right. It's a awkward way.
> > > then, how about moving it libavformat/utils.c and declare it in
> > internal.h?
> >
> > I would slightly prefer asf.c, since it's small and this function is
> > ASF-specific.
> >
> > If other file formats need it, we can move it to utils.c.
> >
> > [...]
> >
> 
> moved it into asf.c.
> see attached patch.
> 
> zhentan
> -- 
> Best wishes~

>  asf.c    |   17 +++++++++++++++++
>  asf.h    |    1 +
>  asfenc.c |   23 +++--------------------
>  3 files changed, 21 insertions(+), 20 deletions(-)
> ba90bc804c7f21f32f1c73718183ec59ebcb3e26  extract_common_fun.patch

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/bb7d904f/attachment.pgp>