[FFmpeg-devel] [patch]MMS protocol over TCP

[zhentan feng]

Hi

On Wed, Mar 24, 2010 at 11:48 PM, Ronald S. Bultje <rsbultje at gmail.com>wrote:

> Hi,
>
> On Wed, Mar 24, 2010 at 11:30 AM, zhentan feng <spyfeng at gmail.com> wrote:
> > On Wed, Mar 24, 2010 at 10:41 PM, Michael Niedermayer <michaelni at gmx.at
> >wrote:
> >> code duplication (in each object including this and using the function)
> >> iam against this, declare the proper dependancies or if you have to move
> >> this to a (maybe new) C file.
> >> [...]
> >
> > yes you are right. It's a awkward way.
> > then, how about moving it libavformat/utils.c and declare it in
> internal.h?
>
> I would slightly prefer asf.c, since it's small and this function is
> ASF-specific.
>
> If other file formats need it, we can move it to utils.c.
>
> [...]
>

moved it into asf.c.
see attached patch.

zhentan
-- 
Best wishes~
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extract_common_fun.patch
Type: application/octet-stream
Size: 2579 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100325/2a9a46fb/attachment.obj>