[FFmpeg-devel] [PATCH] Move error codes definitions from lavc to lavu

[Stefano Sabatini]

On date Thursday 2010-03-11 00:14:34 +0100, Stefano Sabatini encoded:
> On date Tuesday 2010-03-09 01:09:21 +0100, Stefano Sabatini encoded:
> > On date Tuesday 2010-03-09 00:49:52 +0100, Michael Niedermayer encoded:
> > > On Tue, Mar 09, 2010 at 12:04:55AM +0100, Stefano Sabatini wrote:
> > > > On date Monday 2010-03-08 23:12:06 +0100, Michael Niedermayer encoded:
> > > > > On Mon, Mar 08, 2010 at 10:57:59PM +0100, Stefano Sabatini wrote:
> > > > [...] 
> > > > > what i might approve is:
> > > > > move all lines unchanged to a new header
> > > > > move some lines unchanged to a new header
> > > > > 
> > > > > what i will not approve:
> > > > > anything that adds new breakage with a major bump
> > > > > any renamings or sneaked in redesign in a patch moving code
> > > > 
> > > > New try attached.
> > > 
> > > it still wont compile with the version bumped
> > 
> > OK I suppose amongst other things, it is because I have to remove the
> > old symbols still used in libav*, well I'll see to create a complete
> > patch series for that...
> 
> I see two approaches:
> 
> 1) move all the codes from lavc to lavu, remove all the unwanted codes
> uses *and* remove them at the next lavu bump
> 
> 2) remove all the uses of the unwanted codes from lavc, move the
> remaining ones to lavu and drop them at the next lavc bump.
> 
> Approach 1) looks more robust, but I may be wrong.
> 
> Which one do you prefer?

Follows a series of patches following this approach.

While for the other error codes I have no problem at removing them and
use the corresponding AVERROR(EPOSIX) codes, for the following I have
some doubts:

#define AVERROR_NUMEXPECTED AVERROR(EDOM)    /**< Number syntax expected in filename. */
#define AVERROR_INVALIDDATA AVERROR(EINVAL)  /**< invalid data found */
#define AVERROR_NOFMT       AVERROR(EILSEQ)  /**< unknown format */
#define AVERROR_NOTSUPP     AVERROR(ENOSYS)  /**< Operation not supported. */

They seem to be used with very specific FFmpeg meanings, so I don't
know if I should create for them some corresponding AVERROR_ FFmpeg
error code.

Regards.
-- 
FFmpeg = Fierce & Fascinating Merciless Patchable Entertaining Game