[FFmpeg-devel] [PATCH] Move error codes definitions from lavc to lavu

[Michael Niedermayer]

On Thu, Mar 11, 2010 at 01:01:21AM +0100, Stefano Sabatini wrote:
> On date Thursday 2010-03-11 00:14:34 +0100, Stefano Sabatini encoded:
> > On date Tuesday 2010-03-09 01:09:21 +0100, Stefano Sabatini encoded:
> > > On date Tuesday 2010-03-09 00:49:52 +0100, Michael Niedermayer encoded:
> > > > On Tue, Mar 09, 2010 at 12:04:55AM +0100, Stefano Sabatini wrote:
> > > > > On date Monday 2010-03-08 23:12:06 +0100, Michael Niedermayer encoded:
> > > > > > On Mon, Mar 08, 2010 at 10:57:59PM +0100, Stefano Sabatini wrote:
> > > > > [...] 
> > > > > > what i might approve is:
> > > > > > move all lines unchanged to a new header
> > > > > > move some lines unchanged to a new header
> > > > > > 
> > > > > > what i will not approve:
> > > > > > anything that adds new breakage with a major bump
> > > > > > any renamings or sneaked in redesign in a patch moving code
[...]
> Subject: [PATCH 1/8] Move error code definitions from libavcodec/avcodec.h to
>  libavutil/error.h.
> 
> Error code definitions and handling code belong to libavutil, where
> they can be shared by all the libav* libraries.
[...]
> -#define AVERROR(e) (-(e)) /**< Returns a negative error code from a POSIX error code, to return from library functions. */
> -#define AVUNERROR(e) (-(e)) /**< Returns a POSIX error code from a library function error return value. */
[...]
> +#define AVERROR(e) (-(e))
> +#define AVUNERROR(e) (-(e)) /**< Returns a POSIX error code from a library function error return value. */

How do you manage to not be able to move 5 lines unchanged from one file
to another
look, you waste your time, you waste my time repeatly reviewing your code
to find the very identical issue. We both likely have more important things
to do. And this is straining my nerves quite a bit, i suggest you dont
submit this move again with changes to the lines. Either start with a
fresh checkout and free from all weird version control tools except svn
and then just move these lines to a new header with your editor or it
might be better you dont submit this again

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100311/5853d880/attachment.pgp>