[FFmpeg-devel] [PATCH] SHOUTcast HTTP Support

[Michael Niedermayer]

On Fri, Mar 05, 2010 at 09:36:54AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Mar 4, 2010 at 7:16 PM, Micah F. Galizia <micahgalizia at gmail.com> wrote:
> >> So why don't you strip this off as well in the second probe?
> >
> > To recap, on Michael's recommendation, I'm putting the probe loop from
> > utils.c in its own method so the shoutcast demuxer can use it too.
> 
> ... with the output of the icy demuxer, not its input.
> 
> You're not trying to probe the data of the icy demuxer input. That is
> icy. We know that. You already are the demuxer for it. In fact, if the
> icy-internal-probe finds that the data is mp3, I would say that you
> just found a bug in your icy demuxer probing code.
> 
> You want to feed it (somehow, e.g. by providing a new URLProtocol on
> top of the icy demuxer) the OUTPUT of the icy demuxer. That should be
> valid, framed and good mp3, requiring none of this patch.
> 
> At least I thought that was what you were going to do.

the way i understood it, is that the stream in there is actually
not good mp3 but rather good mp3 cut at random unknown to us byte
offset

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100305/7634d6f8/attachment.pgp>