[FFmpeg-devel] [PATCH] SHOUTcast HTTP Support

[Ronald S. Bultje]

Hi,

On Thu, Mar 4, 2010 at 7:16 PM, Micah F. Galizia <micahgalizia at gmail.com> wrote:
>> So why don't you strip this off as well in the second probe?
>
> To recap, on Michael's recommendation, I'm putting the probe loop from
> utils.c in its own method so the shoutcast demuxer can use it too.

... with the output of the icy demuxer, not its input.

You're not trying to probe the data of the icy demuxer input. That is
icy. We know that. You already are the demuxer for it. In fact, if the
icy-internal-probe finds that the data is mp3, I would say that you
just found a bug in your icy demuxer probing code.

You want to feed it (somehow, e.g. by providing a new URLProtocol on
top of the icy demuxer) the OUTPUT of the icy demuxer. That should be
valid, framed and good mp3, requiring none of this patch.

At least I thought that was what you were going to do.

Ronald