[FFmpeg-devel] [fix-multiple-filter-chain.patch PATCH 3/3] Cosmetics: rename enc -> avctx in opt_input_file(), the variable refer to a *decoder*, the old name was misleading.

[Michael Niedermayer]

On Sat, Jul 17, 2010 at 01:04:00PM +0200, Stefano Sabatini wrote:
> On date Friday 2010-07-09 16:11:12 +0200, Michael Niedermayer encoded:
> > On Fri, Jul 09, 2010 at 12:56:24AM +0200, Stefano Sabatini wrote:
> > > On date Wednesday 2010-07-07 20:26:15 +0200, Michael Niedermayer encoded:
> > > > On Wed, Jul 07, 2010 at 08:03:29PM +0200, Stefano Sabatini wrote:
> > > > > ---
> > > > >  ffmpeg.c |   44 ++++++++++++++++++++++----------------------
> > > > >  1 files changed, 22 insertions(+), 22 deletions(-)
> > > > 
> > > > if its a decoder iz should be called dec
> > > 
> > > Sorry the commmit message was wrong, the variable is a decoder
> > > *context* not a decoder, in this regards the use of avctx makes sense.
> > 
> > dec= DEcoderContext then.
> 
> That would be inconsistent with other parts of ffmpeg.c (and most
> FFmpeg code). Also the more natural interpretation of dec is DECoder.

grep 'AVCodec ' ffmpeg.c
static AVCodec *input_codecs[MAX_FILES*MAX_STREAMS];
static AVCodec *output_codecs[MAX_FILES*MAX_STREAMS];
static void choose_sample_fmt(AVStream *st, AVCodec *codec)
static void choose_sample_rate(AVStream *st, AVCodec *codec)
static void choose_pixel_fmt(AVStream *st, AVCodec *codec)
        AVCodec *codec;
            AVCodec *codec = output_codecs[i];
            AVCodec *codec = input_codecs[i];
    AVCodec *codec;
        AVCodec *codec;
        AVCodec *codec;
--------
100% consistent

grep AVCodecContext ffmpeg.c
    AVCodecContext *codec = ost->st->codec;
    AVCodecContext *icodec = ist->st->codec;
static void write_frame(AVFormatContext *s, AVPacket *pkt, AVCodecContext *avctx, AVBitStreamFilterContext *bsfc){
    AVCodecContext *enc= ost->st->codec;
    AVCodecContext *dec= ist->st->codec;
    AVCodecContext *dec;
    AVCodecContext *enc;
    AVCodecContext *enc, *dec;
    AVCodecContext *enc;
    AVCodecContext *enc;
                AVCodecContext *enc= ost->st->codec;
    AVCodecContext *codec, *icodec;
        AVCodecContext *enc = st->codec;
            AVCodecContext *enc = ic->streams[i]->codec;
    AVCodecContext *video_enc;
    AVCodecContext *audio_enc;
    AVCodecContext *subtitle_enc;
                        AVCodecContext *c = input_files[j]->streams[i]->codec;
---------
quite consistent as well, and enc/dec is the most common by a large margin



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100717/72031568/attachment.pgp>