[FFmpeg-devel] [PATCH] RTP depacketizer for AMR

[Luca Barbato]

On 01/27/2010 02:09 PM, Luca Abeni wrote:
> Hi Martin,
> 
> Martin Storsj? wrote:
>> Hi,
>>
>> Here's the first shot at an RTP depacketizer for AMR. It has been
>> tested with libavformat's RTP AMR packetizer, QuickTime Broadcaster
>> and samples from Darwin Streaming Server.
> 
> Nice work, thanks!
> 
> 
>> Currently, this returns the AMR frames from the packet one at a time,
>> by buffering up the packet within the depacketizer.
>>
>> I also tried returning all frames at once, but ffmpeg.c gives the
>> "Multiple frames in a packet from stream" error message (but works
>> fine except for that).
> 
> I think that if you return all the frames at once, you need an AMR parser
> (which I do not think we currently have...).
> So, I'd say that returning one frame at time is ok.
> 
> I leave the patch review to the maintainer, but it looks almost
> fine to me.
> The only thing that looks debatable is the fact that the payload parser
> touches the timestamp. I believe the timestamp should only be modified
> by rtpdec.c::rtp_parse_packet() (in other word, the first frame of the
> RTP packet is assigned the RTP timestamp, the other frames get
> AV_NOPTS_VALUE). I think libavformat can correctly fill the missing
> timestamps... Can you try it and see what happens?

the problem is that sometimes you may have wacky way to map rtp
timestamp with the codec timestamp (since rtp is overly flexible) so
some codec might need to mess at this level =|

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero