[FFmpeg-devel] [PATCH] RTP depacketizer for AMR

Michael Niedermayer michaelni
Wed Jan 27 14:14:04 CET 2010

On Wed, Jan 27, 2010 at 02:50:36PM +0200, Martin Storsj? wrote:
> Hi,
> Here's the first shot at an RTP depacketizer for AMR. It has been tested 
> with libavformat's RTP AMR packetizer, QuickTime Broadcaster and samples 
> from Darwin Streaming Server.
> Currently, this returns the AMR frames from the packet one at a time, by 
> buffering up the packet within the depacketizer.

> I also tried returning all frames at once, but ffmpeg.c gives the 
> "Multiple frames in a packet from stream" error message (but works fine 
> except for that).

is there a meassureable difference in speed between returning all and
spliting? Spliting is preferred but if there are speed advantages then
we might think about detecting the cases where spliting is unneeded and
avoid it. (its unneeded when decoding, needed when doing stream copy)

> Is returning one frame at a time in this way ok, or should an AMR parser 
> be added to handle the splitting?

If one way is more efficient (fewer memcpy) then this one should be prefered
otherwise ive no oppinion currently about this

no comment on the patch as i didn review it

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100127/07a0145d/attachment.pgp>

More information about the ffmpeg-devel mailing list