[FFmpeg-devel] [PATCH] libavdevice: make device_try_init static

[Michael Niedermayer]

On Mon, Jan 04, 2010 at 07:00:20PM +0100, Reimar D?ffinger wrote:
> On Mon, Jan 04, 2010 at 06:32:16PM +0100, Luca Abeni wrote:
> > Hi Diego,
> > 
> > On 03/01/10 12:55, Diego Biurrun wrote:
> > > On Sun, Jan 03, 2010 at 11:45:28AM +0100, Luca Abeni wrote:
> > >> On 02/01/10 10:44, Reinhard Tartler wrote:
> > >>> $subj.
> > >>
> > >> Patch applied, thanks! BTW, do you have some automated scripts or tools
> > >> for performing this kind of checks? It could be interesting to integrate
> > >> them in FATE, or similar...
> > >
> > > -Wmissing-prototypes
> > > -Wmissing-declarations
> > 
> > Thanks for the information, this is very useful!
> > What about adding those switches to ffmpeg compilation? I do not know 
> > the build system very much, but I am wondering if the attached patch is 
> > acceptable.
> > 
> > I tested it, and it even produced some new warnings ;-)
> > 
> > 
> > 			Thanks,
> > 				Luca
> 
> > Index: configure
> > ===================================================================
> > --- configure	(revision 21012)
> > +++ configure	(working copy)
> > @@ -2519,6 +2519,8 @@
> >  check_cflags -Wwrite-strings
> >  check_cflags -Wtype-limits
> >  check_cflags -Wundef
> > +check_cflags -Wmissing-prototypes
> > +check_cflags -Wmissing-declarations
> >  enabled extra_warnings && check_cflags -Winline
> 
> I'd personally prefer to use -Werror=... for some of those...
> Particularly for -Wold-style-declaration or what it is called, so we
> don't have to point out the missing void in function declarations with
> no arguments during review...

i agree

though not all warnings work with -Werror, gcc had the habit of ignoring
some things.
Also we must make sure that that new -Werror dont cause compilation
failures on a small subset of systems because that would be kinda annoying

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100104/4e72e9e5/attachment.pgp>