[FFmpeg-devel] [PATCH] libavdevice: make device_try_init static
Mon Jan 4 19:00:20 CET 2010
On Mon, Jan 04, 2010 at 06:32:16PM +0100, Luca Abeni wrote:
> Hi Diego,
> On 03/01/10 12:55, Diego Biurrun wrote:
> > On Sun, Jan 03, 2010 at 11:45:28AM +0100, Luca Abeni wrote:
> >> On 02/01/10 10:44, Reinhard Tartler wrote:
> >>> $subj.
> >> Patch applied, thanks! BTW, do you have some automated scripts or tools
> >> for performing this kind of checks? It could be interesting to integrate
> >> them in FATE, or similar...
> > -Wmissing-prototypes
> > -Wmissing-declarations
> Thanks for the information, this is very useful!
> What about adding those switches to ffmpeg compilation? I do not know
> the build system very much, but I am wondering if the attached patch is
> I tested it, and it even produced some new warnings ;-)
> Index: configure
> --- configure (revision 21012)
> +++ configure (working copy)
> @@ -2519,6 +2519,8 @@
> check_cflags -Wwrite-strings
> check_cflags -Wtype-limits
> check_cflags -Wundef
> +check_cflags -Wmissing-prototypes
> +check_cflags -Wmissing-declarations
> enabled extra_warnings && check_cflags -Winline
I'd personally prefer to use -Werror=... for some of those...
Particularly for -Wold-style-declaration or what it is called, so we
don't have to point out the missing void in function declarations with
no arguments during review...
More information about the ffmpeg-devel