[FFmpeg-devel] [PATCH] Detect DTS in wav (issue70) ???+?about?ac3-in-wav

[Michael Niedermayer]

On Wed, Aug 18, 2010 at 08:24:58AM +0300, Anssi Hannula wrote:
> On Wednesday 18 August 2010 07:29:15 Anssi Hannula wrote:
> > On Tuesday 17 August 2010 15:26:52 Michael Niedermayer wrote:
> > > i meant that the code is a mess and id like it to be simpler.
> > 
> > Attached is a completely different simpler approach, then.
> > Since we are about to do the
> > lower-wav-score-for-s16le-files-if-small-buffer trick anyway for the
> > spdif-in-wav files, attached patch does the same for dts- in-wav, marking
> > such files as raw dts.
> > 
> > Better?

no, its still a mess
everything looks much more complex than it should be and its not clear
at all why the changes are done.
a patch touching probe functions from 2 seperate formats is already quite
suspect.
if dts detection is not good enough it can be improved in a seperate
patch
and each improvement should be seperate and be justified
for example why do you add such huge amounts of code, is the dts detection
failing for you?
checking for identical markers should not need more than 4 lines of code
like
if(last == current) identical ++;
else                different ++;
if(identical - A*different > B)
    return C

the changes to wav.c do look ok but should be seperate as well

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100818/722997e7/attachment.pgp>