[FFmpeg-devel] [PATCH] Detect DTS in wav (issue70) ???+?about?ac3-in-wav
Wed Aug 18 12:38:11 CEST 2010
On Wed, Aug 18, 2010 at 12:33:11PM +0200, Michael Niedermayer wrote:
> On Wed, Aug 18, 2010 at 08:24:58AM +0300, Anssi Hannula wrote:
> > On Wednesday 18 August 2010 07:29:15 Anssi Hannula wrote:
> > > On Tuesday 17 August 2010 15:26:52 Michael Niedermayer wrote:
> > > > i meant that the code is a mess and id like it to be simpler.
> > >
> > > Attached is a completely different simpler approach, then.
> > > Since we are about to do the
> > > lower-wav-score-for-s16le-files-if-small-buffer trick anyway for the
> > > spdif-in-wav files, attached patch does the same for dts- in-wav, marking
> > > such files as raw dts.
> > >
> > > Better?
> no, its still a mess
> everything looks much more complex than it should be and its not clear
> at all why the changes are done.
i realize now why it makes sense to check tha padding, to fail if dts is
stored in a outer format that adds headers between. This should be documented
also the code looks duplicated relative to spdif_header_dts()
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 190 bytes
Desc: Digital signature
More information about the ffmpeg-devel