[FFmpeg-devel] [PATCH] Add Apple HTTP Live Streaming protocol handler

[Ronald S. Bultje]

Hi,

On Tue, Aug 17, 2010 at 9:11 AM, Martin Storsj? <martin at martin.st> wrote:
> On Mon, 16 Aug 2010, Ronald S. Bultje wrote:
>> On Thu, Aug 5, 2010 at 4:20 PM, Martin Storsj? <martin at martin.st> wrote:
>> > New patch attached.
>> [..]
>> > +#define MAX_URL_LEN 2048
>>
>> MAXPATHLEN, PATH_MAX (is the same) or FILENAME_MAX? These already
>> exist as part of the posix standard, I think.
>
> Yes, but they refer to slightly different things. In general, I'd imagine
> the longest URL being a bit longer than the longest local path (given that
> urls can have a long list of query parameters, too). In http.c, we have
> URL_SIZE 4096, too.

You're right. Any chance you could move the HTTP define to internal.h
or something so we can use that here also? It's nice to be
consistent...

I'll give it a quick test and then you can probably apply. Nothing
more from me unless testing shows fuzzy stuff (I just want to see how
it behaves for a little.)

Ronald