[FFmpeg-devel] [PATCH] Add Apple HTTP Live Streaming protocol handler

[Martin Storsjö]

Hi Ronald,

Thanks for looking at this again :-)

On Mon, 16 Aug 2010, Ronald S. Bultje wrote:

> On Thu, Aug 5, 2010 at 4:20 PM, Martin Storsj? <martin at martin.st> wrote:
> > New patch attached.
> [..]
> > +#define MAX_URL_LEN 2048
> 
> MAXPATHLEN, PATH_MAX (is the same) or FILENAME_MAX? These already
> exist as part of the posix standard, I think.

Yes, but they refer to slightly different things. In general, I'd imagine 
the longest URL being a bit longer than the longest local path (given that 
urls can have a long list of query parameters, too). In http.c, we have 
URL_SIZE 4096, too.

> In general, looks quite sane. I'll probably want to test it a little
> (do you have a sample URL handy?), but don't expect any major revision
> suggestions from me, I'm happy with the way it looks now.

http://devimages.apple.com/iphone/samples/bipbop/bipbopall.m3u8

http://devimages.apple.com/iphone/samples/bipbop/gear1/prog_index.m3u8
(and similar for gear1-gear4) for the specific bitrate variants if you 
want to play one particular at a time.

> Having said that, at some point in the future it'd be nice to have a
> more generic playlist API which provides an interface (maybe metadata
> or so) so the application "knows" what files are contained in the
> playlist. Not a requirement (for me, at least) to get this committed,
> though, but more something like a feature request if you get bored in
> the far future...

Yes, that's a nice to have feature, but not within the scope of this 
patch.

Ok to apply?

// Martin