[FFmpeg-devel] [PATCH] Zero-initialize the reply struct in ff_rtsp_connect

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Sun, Apr 04, 2010 at 10:11:07PM +0100, M?ns Rullg?rd wrote:
>> > With older gccs it resulted in a good bit slower code at least.
>> 
>> How old?  What about more recent ones?
>
> I don't know. I guess 3.4. Replacing all {0} by memset in libfaad
> resulted in quite a speedup.
> And actually there might be similar issues with even (IIRC) 4.3 on ARM
> due to gcc clobbering struct alignment somewhere on the way down,
> but I only know that this can cause issues with struct assignment
> vs. memcpy in very specific cases (the assignment would become a
> memcpy call, while the memcpy would be inlined).

Do you have specific examples of this happening?

-- 
M?ns Rullg?rd
mans at mansr.com