[FFmpeg-devel] [PATCH] Redefine AVERROR_EOF as a specific FFmpeg error code at the next lavu major bump

Stefano Sabatini stefano.sabatini-lala
Sat Apr 3 17:08:48 CEST 2010


On date Sunday 2010-03-14 20:01:16 +0100, Michael Niedermayer encoded:
> On Sat, Mar 13, 2010 at 09:20:21PM +0100, Stefano Sabatini wrote:
> > Hi, $subj.
> > -- 
> > FFmpeg = Fast & Fierce Mastodontic Plastic Easy Guide
> 
> >  error.h |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 0e189262c6eff5c66cb595e68e06d46cccedd7e4  0005-Change-the-definition-of-AVERROR_EOF-at-the-next-lib.patch
> > >From aff03d4184558d02b6f20605eb1adc32a9eade39 Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > Date: Sat, 13 Mar 2010 21:17:06 +0100
> > Subject: [PATCH 5/5] Change the definition of AVERROR_EOF at the next libavutil major bump,
> >  using an FFmpeg specific error code rather than EPIPE, which has a
> >  quite different semantics.
> 
> there are matches for EPIPE in the source, i am thus not in favor of this
> patch because you wont debug and fix the resulting bugs rather i would
> have too.

Apart from some occurrences which I addressed in other patches, there
are some matches of AVERROR(EPIPE) in rtspenc.c:rtsp_write_packet()
where its use looks correct (from a chat with Martin: "we're trying to
send data, but the server closed the connection for some reason").

Regression test passed (both with LIBAVUTIL_MAJOR_VERSION == 50 and ==
51).

Regards.
-- 
FFmpeg = Friendly and Funny Magical Purposeless Extravagant Gadget



More information about the ffmpeg-devel mailing list