[FFmpeg-devel] [PATCH] Fix build with --disable-{encoders, muxers}

Diego Biurrun diego
Fri Sep 18 11:00:27 CEST 2009


On Tue, Sep 15, 2009 at 08:42:45PM +0000, Jai Menon wrote:
> 
> I think the snow code doesnt conditionally exclude encoder specific
> functionality during compilation and references functions (eg.
> h263_encode_init) which arent compiled in. Ex - ./configure .....
> --disable-encoders --disable--muxers....
> Attached patch might not be complete and maybe more functions can be
> folded into an #if CONFIG_ENCODERS. But it fixes the build for me.

This is very much suboptimal.  At the very least, you should use
CONFIG_SNOW_ENCODER instead.  As a step up from that, you could reorder
the functions in a sensible way so that you need less, maybe even just
one #ifdef.  The proper solution would be to split the file.

And yes, the code should compile with either decoder or encoder
disabled.

Diego



More information about the ffmpeg-devel mailing list