[FFmpeg-devel] [PATCH] Fix build with --disable-{encoders, muxers}

[Michael Niedermayer]

On Wed, Sep 16, 2009 at 11:31:52AM +0530, Jai Menon wrote:
> On Wed, Sep 16, 2009 at 2:23 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Sep 15, 2009 at 08:42:45PM +0000, Jai Menon wrote:
> >> Hi,
> >>
> >> I think the snow code doesnt conditionally exclude encoder specific
> >> functionality during compilation and references functions (eg.
> >> h263_encode_init) which arent compiled in. Ex - ./configure .....
> >> --disable-encoders --disable--muxers....
> >> Attached patch might not be complete and maybe more functions can be
> >> folded into an #if CONFIG_ENCODERS. But it fixes the build for me.
> >
> > iam against adding dozends of #ifs in snow.c
> 
> Fair enough, but is there any other way then, that is without having
> to disable the decoder as well? The only reason I brought this up is
> (given the fact the buildsystem allows for such ./configure'ations),
> users might end up trying this and report these as issues....

AVCodec snow_encoder
is under an #ifdef and disabled
thus all the encoder specific functions should not be referenced by anything
except themselfs and they should all be static.
IMO an optimizing compiler should even at -O0 remove unused static functions
its trivial for it to do so and its fast and once the functions are gone
linking cant fail, besides if the compiler removes them early it doesnt have
to spend time compiling them ...
i do consider this a bug in the compiler

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090916/34515d1e/attachment.pgp>