[FFmpeg-devel] [bug/patch] MPEG-TS muxer: PCR not in sync withPTS/DTS

[Michael Niedermayer]

On Thu, Oct 01, 2009 at 02:11:29PM +0200, Niobos wrote:
> On 17 Sep 2009, at 08:48, Niobos wrote:
>> On 09 Sep 2009, at 14:01, Niobos wrote:
>>> You are correct, although it hardly matters: 70bps with the current 
>>> PCR_RETRANS_TIME.
>>> Adapted patch (against r19796) in attachment
>>> <ffmpeg-mpegts-vbr-3.diff>
>>
>> This thread has been silent for over a week now.
>>
>> What is the status of this patch? Is there anything more I need to do to 
>> get this included?
>
> I reviewed this patch since I needed some additional features:
> * Bugfix: In VBR mode, the SI-table period was calculated on the muxrate 
> after it had been multiplied by 10. The resulting rates were 10x to slow.
> * Extra feature: Specifying a negative muxrate on the commandline 
> overwrites the calculated muxrate, but still activates VBR.
> * I added an additional patch which includes some additional 
> info/clarification and does not cause any changes in the compiled code.
>
> This extra feature is needed to produce a VBR MPEG-TS by remultiplexing a 
> source ("-{a,v}codec copy"), since the bitrates can't be learned from the 
> stearm.
>
> Attached patches are against r20080.
[...]

>  mpegtsenc.c |   64 ++++++++++++++++++++++++++++++++++++++++++++----------------
>  options.c   |    2 -
>  2 files changed, 48 insertions(+), 18 deletions(-)
> 8379b5dc6eca030239c061436c56f32180626ab1  ffmpeg-mpegts-vbr-4.diff
> Index: libavformat/options.c
> ===================================================================
> --- libavformat/options.c	(revision 20080)
> +++ libavformat/options.c	(working copy)
> @@ -41,7 +41,7 @@
>  
>  static const AVOption options[]={
>  {"probesize", "set probing size", OFFSET(probesize), FF_OPT_TYPE_INT, 5000000, 32, INT_MAX, D},
> -{"muxrate", "set mux rate", OFFSET(mux_rate), FF_OPT_TYPE_INT, DEFAULT, 0, INT_MAX, E},
> +{"muxrate", "set mux rate", OFFSET(mux_rate), FF_OPT_TYPE_INT, DEFAULT, INT_MIN, INT_MAX, E},
>  {"packetsize", "set packet size", OFFSET(packet_size), FF_OPT_TYPE_INT, DEFAULT, 0, INT_MAX, E},
>  {"fflags", NULL, OFFSET(flags), FF_OPT_TYPE_FLAGS, DEFAULT, INT_MIN, INT_MAX, D|E, "fflags"},
>  {"ignidx", "ignore index", 0, FF_OPT_TYPE_CONST, AVFMT_FLAG_IGNIDX, INT_MIN, INT_MAX, D, "fflags"},

iam against such hacks, rates are positive values
about the rest of the patch, no comment, ive not reviewed it.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091001/23a4a4fe/attachment.pgp>