[FFmpeg-devel] [PATCH] Add scale filter

[Michael Niedermayer]

On Mon, Nov 09, 2009 at 09:23:59PM +0100, Stefano Sabatini wrote:
> On date Sunday 2009-11-08 19:17:57 +0100, Stefano Sabatini encoded:
> > On date Sunday 2009-11-08 03:55:15 +0100, Michael Niedermayer encoded:
> > > On Sun, Nov 08, 2009 at 01:45:10AM +0100, Stefano Sabatini wrote:
> > [...]
> > > >  doc/libavfilter.texi     |   25 +++++
> > > >  libavfilter/Makefile     |    1 
> > > >  libavfilter/allfilters.c |    1 
> > > >  libavfilter/vf_scale.c   |  203 +++++++++++++++++++++++++++++++++++++++++++++++
> > > >  4 files changed, 230 insertions(+)
> > > > 52fe47370a211f1b3e4f17573d8bc5139af5d371  add-scale-filter.patch
> > > 
> > > ok if extensively tested and it passes all tests
> > 
> > I'll apply it soon, of course this won't make the codectest pass, as
> > the scale filter currently doesn't allow to set the swscaler
> > algorithm.
> 
> Also there are some problems with PAL formats.
> 
> I only tried with the samples:
> 
> V-codecs/CVID/palette/catfight Tag team DT.mov
> avi/palette_change/toon.avi
> 
> and both show a palette randomization.
> 
> The problem is issued both with the soc version of the filter and with
> that in the patch, but not with the main repo ffmpeg, and is due with
> all probability to the auto-insertion of a scale filter.
> 

> I didn't investigated a lot on the problem, anyway I won't commit this
> patch until I will understand the problem, 

thanks


> if someone wants to help
> he's very welcome as always, especially considering that I won't have
> much time to dedicate to it in the next few days.

i have several patches i need to review, some bugs i wanted to look at
since a long time and a few other things, so dont expect me looking
into this, sorry


> 
> And BTW I noticed other problems when dealing with paletted formats
> (main repo ffmpeg):
> 
> ffmpeg -i toon.avi                  -vcodec rawvideo toon-pal8.avi
> ffmpeg -i toon.avi -pix_fmt yuv444p -vcodec rawvideo toon-yuv444.avi
> ffmpeg -i toon.avi -pix_fmt rgb32   -vcodec rawvideo toon-rgb32.avi
> 
> all these give funny results.

if you think there are bugs report them on ou tracker, here it likely
will be forgotten unless someone has time and interrest right away to
look into it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091109/4574657e/attachment.pgp>