[FFmpeg-devel] [PATCH] Add scale filter

Stefano Sabatini stefano.sabatini-lala
Mon Nov 9 21:23:59 CET 2009

On date Sunday 2009-11-08 19:17:57 +0100, Stefano Sabatini encoded:
> On date Sunday 2009-11-08 03:55:15 +0100, Michael Niedermayer encoded:
> > On Sun, Nov 08, 2009 at 01:45:10AM +0100, Stefano Sabatini wrote:
> [...]
> > >  doc/libavfilter.texi     |   25 +++++
> > >  libavfilter/Makefile     |    1 
> > >  libavfilter/allfilters.c |    1 
> > >  libavfilter/vf_scale.c   |  203 +++++++++++++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 230 insertions(+)
> > > 52fe47370a211f1b3e4f17573d8bc5139af5d371  add-scale-filter.patch
> > 
> > ok if extensively tested and it passes all tests
> I'll apply it soon, of course this won't make the codectest pass, as
> the scale filter currently doesn't allow to set the swscaler
> algorithm.

Also there are some problems with PAL formats.

I only tried with the samples:

V-codecs/CVID/palette/catfight Tag team DT.mov

and both show a palette randomization.

The problem is issued both with the soc version of the filter and with
that in the patch, but not with the main repo ffmpeg, and is due with
all probability to the auto-insertion of a scale filter.

I didn't investigated a lot on the problem, anyway I won't commit this
patch until I will understand the problem, if someone wants to help
he's very welcome as always, especially considering that I won't have
much time to dedicate to it in the next few days.

And BTW I noticed other problems when dealing with paletted formats
(main repo ffmpeg):

ffmpeg -i toon.avi                  -vcodec rawvideo toon-pal8.avi
ffmpeg -i toon.avi -pix_fmt yuv444p -vcodec rawvideo toon-yuv444.avi
ffmpeg -i toon.avi -pix_fmt rgb32   -vcodec rawvideo toon-rgb32.avi

all these give funny results.

FFmpeg = Fantastic & Fundamental Mortal Pacific Elastic Guru

More information about the ffmpeg-devel mailing list