[FFmpeg-devel] [PATCH] http Transfer-Encoding chunked

Ronald S. Bultje rsbultje
Mon May 25 16:35:48 CEST 2009


On Mon, May 25, 2009 at 10:28 AM, Peter Holik <peter at holik.at> wrote:
> I reworked my patch with no limitation and set filesize to -1.

Thanks! Minor nitpicks now:
- please use uint64_t for chunksize
- strncmp(p, "chunked", 7) -> please use strncasecmp(), I've seen
"Chunked" and "chunked" be used
- (optional) you're now using 2 variables for chunks: chunked
(boolean) and chunksize. You could consider setting chunksize to -1
(0xFFFFFFFFFFFFFFFFULL) by default and setting it to 0 if chunked.
Michael might disagree, if he does, follow whatever he says (and be
sure to document the variable appropriately if you do this)
- document chunk_size and its relation to file_size please, and if
yuou keep chunked, please document that also


More information about the ffmpeg-devel mailing list