[FFmpeg-devel] FW: pts/dts generation and index for mpegts (vob)

[Baptiste Coudurier]

Hi,

On 6/16/2009 11:49 AM, Erik Van Grunderbeeck wrote:
> 
> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu
> [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Erik Van
> Grunderbeeck
> Sent: Saturday, May 02, 2009 7:41 AM
> To: 'FFmpeg development discussions and patches'
> Subject: Re: [FFmpeg-devel] pts/dts generation and index for mpegts (vob)
> 
>> its on topic here and welcome
>> support of chapter/menu/... is definitly nice
>>
> 
> <cut a length email>
> 
> Ping. Just want to know if there is any interest in this. If not, will stop
> bugging. If yes, would like some comments or just a plain no/yes?

There is definitely an interest. Patch is huge though and will be long to
review. Thanks for your work.

> /*
>  * BMP image format decoder
>  * Copyright (c) 2005 Mans Rullgard
>  *

Copy-paste ?
Is this code based on something else ?

> [...]
>
> typedef struct AVAttachmentParseContext {
> 	//	type
> 	uint16_t			m_Type;
> 
> 	//	when waiting
> 	uint16_t			m_Wait;
> 
> 	//	when buttons
> 	uint16_t			m_HighLightIndex;
> 	uint16_t			m_ButtonCount;
> 	AVAttachmentButton	m_Buttons[MAX_ATTACH_BUTTONS];
> 
> 	//	when color-palette
> 	uint32_t			m_rgba_palette[16];
> 
> 	//	when chapter change
> 	uint16_t			m_current_chapter;
> 
> 	//	when angle change
> 	uint8_t				m_current_angle;
> 	uint8_t				m_max_angle;
> 
> 	//	pts
> 	double				m_pts;
> } AVAttachmentParseContext;

Can you please remove the leading m_ ?

> [...]
> 
> static int attachment_decode_frame(AVCodecContext *avctx,
>                             void *data, int *data_size,
>                             AVPacket *avpkt)
> [...]

We'd like to have code consistently named, so please avoid pContext,
etc.. I think ctx is is good.

Same for the indentation.

I think this would better have a CODEC_ID_DVDNAVDATA.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org