[FFmpeg-devel] [PATCH] run level decode function for wma &?wmapro

[Michael Niedermayer]

On Fri, Jun 12, 2009 at 11:07:36AM +0200, Sascha Sommer wrote:
> Hi,
> 
> On Donnerstag, 11. Juni 2009, Michael Niedermayer wrote:
> > On Thu, Jun 11, 2009 at 10:17:19PM +0200, Sascha Sommer wrote:
> > > Hi,
> > >
> > > attached patch adds a run level decode function that can be used for both
> > > wma12 and wmapro.
> >
> > could you split it into a patch factorizig the code out and one
> > changing it ?
> > so that code moving around is seperate from functional changes ...
> >
> > [...]
> 
> Attached patch tries to simplify the run level decode code.
> The order of the different cases for the codes is swapped so that the code < 0 
> check can be dropped (may this happen anyway?).

it depends on the vlc table, if there are no unused sequences of bits,
that is every sequence of bits will decode as some code then <0 is not
possible
(if it is possible that <0 happens then it must be checked for and error
concealment be performed) but my gut feeling says MS did not leave unused
codes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090613/c19a1fa7/attachment.pgp>