[FFmpeg-devel] [PATCH] Electronic Arts MAD Decoder

[Peter Ross]

Upatched patch.

On Wed, Jun 10, 2009 at 01:15:21PM +0200, Diego Biurrun wrote:
> On Wed, Jun 10, 2009 at 08:52:58PM +1000, Peter Ross wrote:
> > 
> > Patch updated.
> > 
> > --- libavcodec/eamad.c	(revision 0)
> > +++ libavcodec/eamad.c	(revision 0)
> > @@ -0,0 +1,323 @@
> > +
> > +static av_cold int mad_decode_init(AVCodecContext *avctx)
> 
> All those mad_ prefixes for static functions are pointless.

Alright.

> > +static inline void mad_comp_block(MadContext *t, int mb_x, int mb_y, int j, int mv_x, int mv_y, int add)
> 
> nit: long line
> 
> > +        mad_comp(
> > +            t->frame.data[0] + (mb_y*16 + ((j&2)<<2))*t->frame.linesize[0] + mb_x*16 + ((j&1)<<3),
> > +            t->frame.linesize[0],
> > +            t->last_frame.data[0] + (mb_y*16 + ((j&2)<<2) + mv_y)*t->last_frame.linesize[0] + mb_x*16 + ((j&1)<<3) + mv_x,
> > +            t->last_frame.linesize[0],
> > +            add);
> 
> This looks weird, you do not indent function parameters like this in
> other places.
> 
> Diego
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mad-decoder-r106.diff
Type: text/x-diff
Size: 12898 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090611/c8afe19c/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090611/c8afe19c/attachment.pgp>