[FFmpeg-devel] [PATCH] Electronic Arts MAD Decoder
Michael Niedermayer
michaelni
Thu Jun 11 17:12:46 CEST 2009
On Thu, Jun 11, 2009 at 10:00:39PM +1000, Peter Ross wrote:
> Upatched patch.
>
> On Wed, Jun 10, 2009 at 01:15:21PM +0200, Diego Biurrun wrote:
> > On Wed, Jun 10, 2009 at 08:52:58PM +1000, Peter Ross wrote:
> > >
> > > Patch updated.
> > >
> > > --- libavcodec/eamad.c (revision 0)
> > > +++ libavcodec/eamad.c (revision 0)
> > > @@ -0,0 +1,323 @@
> > > +
> > > +static av_cold int mad_decode_init(AVCodecContext *avctx)
> >
> > All those mad_ prefixes for static functions are pointless.
>
> Alright.
>
> > > +static inline void mad_comp_block(MadContext *t, int mb_x, int mb_y, int j, int mv_x, int mv_y, int add)
> >
> > nit: long line
> >
> > > + mad_comp(
> > > + t->frame.data[0] + (mb_y*16 + ((j&2)<<2))*t->frame.linesize[0] + mb_x*16 + ((j&1)<<3),
> > > + t->frame.linesize[0],
> > > + t->last_frame.data[0] + (mb_y*16 + ((j&2)<<2) + mv_y)*t->last_frame.linesize[0] + mb_x*16 + ((j&1)<<3) + mv_x,
> > > + t->last_frame.linesize[0],
> > > + add);
> >
> > This looks weird, you do not indent function parameters like this in
> > other places.
> >
> > Diego
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at mplayerhq.hu
> > https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
> -- Peter
> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
> Changelog | 1
> doc/general.texi | 1
> libavcodec/Makefile | 1
> libavcodec/allcodecs.c | 1
> libavcodec/avcodec.h | 1
> libavcodec/eamad.c | 318 +++++++++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 323 insertions(+)
> 0f49621b7804551a52cf2d90b47c529441f9489e mad-decoder-r106.diff
looks ok
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090611/d77e583a/attachment.pgp>
More information about the ffmpeg-devel
mailing list