[FFmpeg-devel] [PATCH] Electronic Arts MAD Decoder

[Michael Niedermayer]

On Wed, Jun 10, 2009 at 02:03:52PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Wed, Jun 10, 2009 at 01:37:13PM +0100, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Wed, Jun 10, 2009 at 08:52:58PM +1000, Peter Ross wrote:
> >> >> 
> >> >> Patch updated.
> >> >> 
> >> >> --- libavcodec/eamad.c	(revision 0)
> >> >> +++ libavcodec/eamad.c	(revision 0)
> >> >> @@ -0,0 +1,323 @@
> >> >> +
> >> >> +static av_cold int mad_decode_init(AVCodecContext *avctx)
> >> >
> >> > All those mad_ prefixes for static functions are pointless.
> >> 
> >> I disagree.  When using a debugger, it helps if functions have unique
> >> names.  Setting a breakpoint on, or merely seeing in a call stack, a
> >> name like "decode" is ambiguous at best.  Unique names also help with
> >
> > debuggers should display the file name too
> 
> You've obviously never used a debugger

as unbeliveable as it may be i have, but granted gdb is probably one of
the worst if not the worst debugger.


> if you don't recognise the
> usefulness of unique symbol names.

they are unique with the filename, that said, even without the filename
one generally knows what is in the video file one debugs ... if its 
ea-mad, its kinda obvious what the functions would be ...


> 
> >> editors capable of jumping to a named symbol (emacs, vi, and many
> >> others).
> >
> > if the compiler can figure out which function is meant, so should an
> > editor
> 
> Don't be stupid.

if you consider it stupid to fix a broken editor and better to litter all
code with redundant prefixes to workaround that well i guess ive no further
comment

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090610/80584a16/attachment.pgp>