[FFmpeg-devel] [PATCH] Implement libavcodec/opt.[ch] generic options handling

[Michael Niedermayer]

On Mon, Jan 05, 2009 at 02:04:11PM +0100, Stefano Sabatini wrote:
> Hi all,
> 
> this is my first attempt to move the option handling code from the
> applications to the library, it also should make possible to remove
> the deprecated lavf AVFormatParameters.
> 
> Please comment.
> 
> Regards.
> -- 
> FFmpeg = Furious Faboulous Majestic Picky Encoding/decoding Gangster

> Index: ffmpeg/libavcodec/opt.c
> ===================================================================
> --- ffmpeg.orig/libavcodec/opt.c	2009-01-05 13:49:31.000000000 +0100
> +++ ffmpeg/libavcodec/opt.c	2009-01-05 13:51:55.000000000 +0100
> @@ -114,7 +114,7 @@
>          *o_out = o;
>      if(!o)
>          return AVERROR(ENOENT);
> -    if(!val || o->offset<=0)
> +    if(!val || (o->type != FF_OPT_TYPE_HANDLER && o->offset<=0))
>          return AVERROR(EINVAL);
>  
>      if(o->type == FF_OPT_TYPE_BINARY){

this patch needs a seperate thread and some justification why it would be
a good idea
[...]

and moving the AVOption related code from libav*/utils to libav*/options is
fine if that is really just moving and done with svn cp

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090105/1951e14b/attachment.pgp>