[FFmpeg-devel] [PATCH] Implement libavcodec/opt.[ch] generic options handling

[Stefano Sabatini]

On date Monday 2009-01-05 19:52:58 +0100, Michael Niedermayer encoded:
> On Mon, Jan 05, 2009 at 02:04:11PM +0100, Stefano Sabatini wrote:
> > Hi all,
> > 
> > this is my first attempt to move the option handling code from the
> > applications to the library, it also should make possible to remove
> > the deprecated lavf AVFormatParameters.
> > 
> > Please comment.
> > 
> > Regards.
> > -- 
> > FFmpeg = Furious Faboulous Majestic Picky Encoding/decoding Gangster
> 
> > Index: ffmpeg/libavcodec/opt.c
> > ===================================================================
> > --- ffmpeg.orig/libavcodec/opt.c	2009-01-05 13:49:31.000000000 +0100
> > +++ ffmpeg/libavcodec/opt.c	2009-01-05 13:51:55.000000000 +0100
> > @@ -114,7 +114,7 @@
> >          *o_out = o;
> >      if(!o)
> >          return AVERROR(ENOENT);
> > -    if(!val || o->offset<=0)
> > +    if(!val || (o->type != FF_OPT_TYPE_HANDLER && o->offset<=0))
> >          return AVERROR(EINVAL);
> >  
> >      if(o->type == FF_OPT_TYPE_BINARY){
> 
> this patch needs a seperate thread and some justification why it would be
> a good idea
> [...]

Well, why would this be useful?

This would make possible for example to use the frame size/rate
abbreviation using av_set_string3(), when it is currently possible
only in the ff* tools while, having this facility in the library will
avoid to duplicate the code.

It also may be used for moving other code (e.g.: opt_preset() and
opt_target()) from applications to the library, reducing overall code
duplication and providing an higher level API.

> and moving the AVOption related code from libav*/utils to libav*/options is
> fine if that is really just moving and done with svn cp

Done in a separate thread.

Regards.
-- 
FFmpeg = Friendly Funny Most Pacific Ecletic Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-opt-handler.patch
Type: text/x-diff
Size: 3675 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090108/1041c782/attachment.patch>