[FFmpeg-devel] [PATCH]RTSP Basic Authentication

[Luca Barbato]

Ronald S. Bultje wrote:
> Hi Philip,
> 
> On Mon, Feb 16, 2009 at 1:40 PM, Philip Coombes
> <philip.coombes at zoneminder.com> wrote:
>> Thanks Ronald. I just wanted to make sure that no-one was waiting for me
>> to do anything.
> 
> I was just checkign to apply this, and you could do something,
> actually. So, my impression is that this patch adds the auth-line in
> every RTSP command, is that true? If so, is that necessary? Isn't it
> sufficient to add it just to one command?

I think you cannot avoid it PLAY SETUP DESCRIBE and aren't that useful 
for OPTIONS, TEARDOWN and such, but depends on the implementation I'm 
afraid.

> Secondly, the auth takes 256 bytes, although it will almost always be
> absent, and the 256 might then be too small depending on password. For
> completeness, could you please dynamically allocate the auth string in
> RTSPState (size = ceil(strlen(auth)*6/8.)+1 or something)?

Does it do that in the http equivalent? (if isn't could be useful fix it 
as well)

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero