[FFmpeg-devel] [PATCH]RTSP Basic Authentication

[Ronald S. Bultje]

Hi Philip,

On Mon, Feb 16, 2009 at 1:40 PM, Philip Coombes
<philip.coombes at zoneminder.com> wrote:
> Thanks Ronald. I just wanted to make sure that no-one was waiting for me
> to do anything.

I was just checkign to apply this, and you could do something,
actually. So, my impression is that this patch adds the auth-line in
every RTSP command, is that true? If so, is that necessary? Isn't it
sufficient to add it just to one command?

Secondly, the auth takes 256 bytes, although it will almost always be
absent, and the 256 might then be too small depending on password. For
completeness, could you please dynamically allocate the auth string in
RTSPState (size = ceil(strlen(auth)*6/8.)+1 or something)?

Lastly, if you're going to resend the patch anyway, could you remove
all whitespace around if ( <- this one -> condition <- and this one
->) statements, change auth[128] into auth[1024] just like all other
strings and put the long av_strlcatf() on just one or two lines
instead of 6 like now?

I promise I'll apply when this is addresses. :-).

Ronald